Skip to content

Add new board to nrf port: holyiot_nrf52840 #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 30, 2020
Merged

Add new board to nrf port: holyiot_nrf52840 #3610

merged 12 commits into from
Oct 30, 2020

Conversation

Edrig
Copy link

@Edrig Edrig commented Oct 26, 2020

No description provided.

Edrig and others added 4 commits October 17, 2020 16:54
@Edrig
Update CONTRIBUTING.md
dc10e96
@Edrig
Update CONTRIBUTING.md
7cf776d 
test fix url 404
Ready to PR
5deb045 
        * ../../.github/workflows/build.yml
	+ boards/holyiot_nrf52840/board.c
	+ boards/holyiot_nrf52840/mpconfigboard.h
	+ boards/holyiot_nrf52840/mpconfigboard.mk
	+ boards/holyiot_nrf52840/pins.c
Fix error
cfaa02e
@ladyada
Copy link
Member

ladyada commented Oct 27, 2020

@Edrig hi please get unique PID/VID for this board, you cannot re-use an adafruit USB identifier!
also check some text formatting issues noted in
https://github.com/adafruit/circuitpython/pull/3610/checks?check_run_id=1311673547

@tannewt
Copy link
Member

tannewt commented Oct 27, 2020

Is this a module?

@Edrig
Copy link
Author

Edrig commented Oct 27, 2020

@tannewt its a breackout for use/dev with the cheap holyiot nrf52840 module

https://anderson69s.com/portfolio/nrf52840-breakout-holyiot/

Edrig and others added 5 commits October 27, 2020 23:54
@Edrig
Update pins.c
d0426b3 
fix mistake
Fix EOF error
27827a4 
modifié :         mpconfigboard.mk
modifié :         pins.c
modifié : pins.c
9b911b2
Merge branch 'main' of https://github.com/Edrig/circuitpython into main
b5c95e3 
	modifié :         boards/holyiot_nrf52840/pins.c
fix railing Whitespace pin.c
b44011d
tannewt
tannewt requested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so holyriot isn't actually the manufacturer. Please name based on the board, not the module.

Change Board Name to ADM_B_NRF52840_1
5ab2f16 
edit   :         .github/workflows/build.yml
rename :         ports/nrf/boards/holyiot_nrf52840/board.c -> ports/nrf/boards/ADM_B_NRF52840_1/board.c
rename :         ports/nrf/boards/holyiot_nrf52840/mpconfigboard.h -> ports/nrf/boards/ADM_B_NRF52840_1/mpconfigboard.h
rename :         ports/nrf/boards/holyiot_nrf52840/mpconfigboard.mk -> ports/nrf/boards/ADM_B_NRF52840_1/mpconfigboard.mk
rename :         ports/nrf/boards/holyiot_nrf52840/pins.c -> ports/nrf/boards/ADM_B_NRF52840_1/pins.c
@Edrig
Copy link
Author

Edrig commented Oct 28, 2020

@tannewt we change the board name to ADM_B_NRF52840_1 (AtelierDuMaker_Breakout_NRF52840_1 for first version)

tannewt
tannewt approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit 09ae9ae into adafruit:main Oct 30, 2020
@tannewt
Copy link
Member

tannewt commented Nov 20, 2020

Don't forget to add your board to circuitpython.org: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website

@dhalbert
Copy link
Collaborator

Ping for @Edrig:

Don't forget to add your board to circuitpython.org: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Edrig @ladyada @tannewt @dhalbert