Skip to content

ESP32S2: Support for RotaryIO #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 9, 2020
Merged

ESP32S2: Support for RotaryIO #3614

merged 4 commits into from
Nov 9, 2020

Conversation

microdev1
Copy link
Collaborator

No description provided.

@tannewt tannewt self-requested a review October 30, 2020 19:03
tannewt
tannewt reviewed Oct 30, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Were you able to test it or do you need me to?

@microdev1
Copy link
Collaborator Author

@tannewt Thanks for the review. I tested this with my microS2 & two different types of encoder.

tannewt
tannewt requested changes Nov 3, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change the copyright. Let's wait for #3615 to be merged and then update this PR for the pcnt sharing code. Thanks!

@hierophect
Copy link
Collaborator

Seconding Scott here - if you can get everything in CountIO moved over to a peripherals/pcnt.c file, you can migrate all your init and reset functions over to it, and the two modules will be able to co-exist without accidentally trying to reserve each other's PCNT units. Check out rmt.c for an example - the RMT is used by PulseIn, PulseOut, and Neopixel_write, so they all share the same reservation system, init/deinit, and reset_all functions.

@microdev1 microdev1 marked this pull request as ready for review November 8, 2020 05:50
@microdev1 microdev1 requested a review from tannewt November 8, 2020 05:50
tannewt
tannewt approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@tannewt tannewt merged commit 0ebd4e6 into adafruit:main Nov 9, 2020
@microdev1 microdev1 deleted the rotaryio-S2 branch November 10, 2020 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@microdev1 @hierophect @tannewt