Skip to content

Use correct stubs directory name #3629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2020
Merged

Use correct stubs directory name #3629

merged 2 commits into from
Nov 1, 2020

Conversation

dhalbert
Copy link
Collaborator

The stubs directory is called circuitpython-stubs, not stubs.

@dhalbert
Use correct stubs directory name
073dc87 
The stubs directory is called `circuitpython-stubs`, not `stubs`.
@dhalbert dhalbert requested a review from jepler October 31, 2020 18:50
jepler
jepler previously approved these changes Nov 1, 2020
View reviewed changes
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jepler
Copy link

jepler commented Nov 1, 2020

ugh it's still wrong. Needs the zip -r flag or something?

  adding: circuitpython-stubs/ (stored 0%)

@jepler
Update build.yml
3845db4 
Need to request zip to recurse, because it is not the default
jepler
jepler approved these changes Nov 1, 2020
View reviewed changes
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally looks like a correct stubs file has been uploaded to s3:
https://adafruit-circuit-python.s3.amazonaws.com/bin/stubs/circuitpython-stubs-6.1.0-alpha.0-177-g3845db4bb.zip
turns out that when the branch is made in adafruit/circuitpython instead of jepler/circuitpython the upload steps can be tested. Nice, I didn't realize that.

@dhalbert dhalbert merged commit 6fba68b into main Nov 1, 2020
@dhalbert
Copy link
Collaborator Author

dhalbert commented Nov 1, 2020

Finally looks like a correct stubs file has been uploaded to s3:
https://adafruit-circuit-python.s3.amazonaws.com/bin/stubs/circuitpython-stubs-6.1.0-alpha.0-177-g3845db4bb.zip
turns out that when the branch is made in adafruit/circuitpython instead of jepler/circuitpython the upload steps can be tested. Nice, I didn't realize that.

That was completely unintentional on my part, but good to know!

@dhalbert dhalbert deleted the stubs-dir-name branch November 1, 2020 03:19
@dhalbert dhalbert mentioned this pull request Nov 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @jepler