Skip to content

ESP32S2: Support for FrequencyIO #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 23, 2020
Merged

ESP32S2: Support for FrequencyIO #3704

merged 7 commits into from
Nov 23, 2020

Conversation

microdev1
Copy link
Collaborator

No description provided.

tannewt
tannewt reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't see any issues. Please un-draft as you'd like.

@microdev1
Copy link
Collaborator Author

I would like to add some sort of frequency measurement error correction to this ...maybe in a subsequent PR.

@microdev1 microdev1 marked this pull request as ready for review November 18, 2020 07:32
@microdev1 microdev1 requested a review from tannewt November 18, 2020 07:32
@tannewt tannewt requested a review from hierophect November 18, 2020 19:09
hierophect
hierophect previously requested changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@hierophect hierophect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only one small style note.

@microdev1 microdev1 requested a review from hierophect November 22, 2020 13:59
tannewt
tannewt approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit c67f589 into adafruit:main Nov 23, 2020
@microdev1 microdev1 deleted the frequencyio-S2 branch November 24, 2020 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@hierophect hierophect Awaiting requested review from hierophect

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@microdev1 @tannewt @hierophect