Support SPI flash chips for CIRCUITPY, using non-DMA SPI for now. #465
Conversation
| @@ -29,6 +29,5 @@ STATIC const mp_rom_map_elem_t board_global_dict_table[] = { | |||
| { MP_ROM_QSTR(MP_QSTR_SCK), MP_ROM_PTR(&pin_PB11) }, | |||
| { MP_ROM_QSTR(MP_QSTR_MOSI), MP_ROM_PTR(&pin_PB10) }, | |||
| { MP_ROM_QSTR(MP_QSTR_MISO), MP_ROM_PTR(&pin_PA12) }, | |||
| { MP_ROM_QSTR(MP_QSTR_FLASH_CS), MP_ROM_PTR(&pin_PA13) }, | |||
There was a problem hiding this comment.
I deleted it because it looked like something you might have added for debugging. There are no other named pins for the flash chip (e.g., no FLASH_SCK, etc.). And there were no similar named pins on the Feather M0, so I thought it was just for testing.
There was a problem hiding this comment.
Ok, that may be a hangover from when the SPI bus was shared. Should the others be added or this deleted?
There was a problem hiding this comment.
I'd leave it deleted for now because end-user use of these pins will mess up CIRCUITPY support. If we had some API for enabling/disabling CIRCUITPY on the flash chip, then someone could use the flash chip for something else besides a filesystem, but right now it's dedicated.
| @@ -38,7 +39,9 @@ void common_hal_storage_remount(const char* mount_path, bool readonly) { | |||
| mp_raise_OSError(MP_EINVAL); | |||
| } | |||
|
|
|||
| if (mp_msc_enabled) { | |||
| // TODO(dhalbert): is this is a good enough check? It checks for | |||
| // CDC enabled. There is no "MSC enabled" check. | |||
There was a problem hiding this comment.
I imagine it'd be enough. It shouldn't require a serial connection to be true.
| #include "extmod/vfs.h" | ||
| #include "extmod/vfs_fat.h" | ||
| ======= | ||
| >>>>>>> WIP |
Implemented and tested on Metro M0, Metro M4, and Feather M0 Express.
Note that if you install this, you'll lose access to your old CIRCUITPY drive in internal flash.
A few changes to
shared_dma.c, but that work was interrupted to try using non-DMA SPI first. SPI baud rate calculation moved to new fileperipherals.c, since it can be shared between SAMD21 and SAMD51.storagemodule turned on, but not tested in detail.