Skip to content

objtype: Restore our customized behavior of instance_subscr #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

jepler
Copy link

@jepler jepler commented Apr 29, 2021

For pixelbuf's [] to be able to call _transmit on the Python subclass, we need to do the subscripting operation specially.

For pixelbuf's [] to be able to call _transmit on the Python subclass,
we need to do the subscripting operation specially.
@jepler jepler requested a review from kattni April 29, 2021 16:59
@jerryneedell
Copy link
Collaborator

jerryneedell commented Apr 29, 2021

I tested this on a Funhouse with tip of main -- the Dotstars are working !! yay!


Press any key to enter the REPL. Use CTRL-D to reload.

Adafruit CircuitPython 7.0.0-alpha.1-930-gd1e17fdcc on 2021-04-29; Adafruit FunHome with ESP32S2
>>> 
>>> import adafruit_dotstar
>>> import board
>>> dot = adafruit_dotstar.DotStar(board.DOTSTAR_CLOCK,board.DOTSTAR_DATA,5,brightness=.3)
>>> dot[0] = 0xff
>>> 



this was failing before the PR as reported in #4682 -- also ran the funhouse_simpletest -- works now

kattni
kattni previously approved these changes Apr 29, 2021
Copy link

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully with NeoPixel as well.

Copy link
Collaborator

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested neopixel on a qtpy_m0_haxpress and dotstar on raspberry pi pico and funhouse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants