time.localtime: low timestamps when epoch is 2000 #4762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
reviewed
May 14, 2021
Comment on lines
+251
to
+255
| #if MICROPY_EPOCH_IS_1970 | ||
| if (secs < 0 || (mp_uint_t)secs < TIMEUTILS_SECONDS_1970_TO_2000) { | ||
| #else | ||
| if (secs < 0) { | ||
| #endif |
There was a problem hiding this comment.
Should a conversion routine maybe be added to lib/timeutils that does this check, to isolate epoch checking in one place? I don't think lib/timeutils should necessarily throw an exception, but it could return success/failure on the conversion.
dhalbert
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Epoch is set to 2000 instead of 1970 (
MICROPY_EPOCH_IS_1970set to0), rejecting values lower thanTIMEUTILS_SECONDS_1970_TO_2000intime.localtime()results in rejecting dates before 2030.