Check that select firmwares build on Windows with MSYS2 #4826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration is used by @ladyada and more often than it should we've discovered late that a change introduced problems building there. By adding this to regular CI, hopefully we learn about and fix these issues sooner rather than later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configuration is used by @ladyada (and no other regular developers?) and more often than it should we've discovered late that a change introduced problems building there.
By adding this to regular CI, hopefully we learn about and fix these issues sooner rather than later.
esp-idf specifically doesn't support windows, but the rest all build.
The Makefile changes fix "commandline too long" messages on Windows/msys2 only.