Skip to content

Add LED and GP25 for Cytron Maker Pi Pico #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2021
Merged

Conversation

DavePutz
Copy link
Collaborator

Pin definitions for LED and GP25 were missing. Tested that GP25 does exist on the board and does run the on-board LED.

Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jepler jepler merged commit 7bee37e into adafruit:main Jul 11, 2021
@DavePutz DavePutz deleted the issue_4939 branch July 13, 2021 16:41
@waiweng83
Copy link

Sorry for digging out the old PR as I just noticed this.
@DavePutz For your information, this port is for the MAKER PI RP2040 and it's not for the MAKER PI PICO. Both of them are different boards. Pin GP25 is not connected on MAKER PI RP2040. Can you please revert?

@waiweng83
Copy link

waiweng83 commented Oct 27, 2021

FYI, we do not have custom CircuitPython firmware for MAKER PI PICO as we can use the Raspberry Pi Pico firmware directly.

waiweng83 added a commit to CytronTechnologies/circuitpython that referenced this pull request Nov 1, 2021
microdev1 added a commit that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants