Skip to content

allow usb_hid.Device(..., report_ids=(0,), ...) #5392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Sep 25, 2021

usb_hid.Device report_ids validation did not allow report_id=(0,).

@jepler Thanks for finding this. Could you test with your report-id-less report descriptor? I did not test except to see that it compiles.

@dhalbert dhalbert requested a review from jepler September 25, 2021 22:11
@tannewt tannewt added the usb label Sep 27, 2021
@tannewt tannewt added this to the 7.x.x milestone Sep 27, 2021
@dhalbert
Copy link
Collaborator Author

dhalbert commented Oct 1, 2021

I have now tested this with a keyboard report descriptor without a Report ID, and gave report_ids=(0,). No errors are reported and the report descriptor works (I sent keystrokes to a host.).

@jepler are you able to review?

@dhalbert dhalbert requested a review from tannewt October 5, 2021 22:48
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request

@microdev1
Copy link
Collaborator

Force pushed to fix a translations issue.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 75db5a2 into adafruit:main Oct 7, 2021
@dhalbert dhalbert deleted the report-id-0 branch October 7, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants