Fix boot_out.txt contents check #5535
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Nov 1, 2021
dhalbert
force-pushed
the
fix-boot_out-check
branch
from
79be39e to
b1c585f
Compare
|
Force-pushed correct changes. |
dhalbert
force-pushed
the
fix-boot_out-check
branch
from
b1c585f to
e07c5c2
Compare
|
This PR will likely be closed in favor of #5536 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boot_out.txtwas getting rewritten every time, because the contents check did not include checking for the newBoard ID:info.I checked to see whether a longer concatenated string or two string comparisons was smaller in terms of firmware space. The latter was better.
I also reduced the time spent waiting for stable power from 1.5 seconds to 1 second.
Note that the existence of a
boot.pywill causeboot_out.txtto be written every time, since we don't know what will get written. It could get buffered instead, and then compared, to save flash writes, but that's more complicated.Anybody can review.