Skip to content

Enable bitmaptools on the 'unix' build, 'coverage' variant #5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 12, 2021

Conversation

jepler
Copy link

@jepler jepler commented Nov 12, 2021

This allows testing & debugging of bitmaptools routines like alphablend & dither on host computers. It shouldn't change anything about how displayio/bitmaptools work on microcontrollers.

$ ./micropython-coverage 
MicroPython 7.1.0-beta.0-3-gd55388a17 on 2021-11-12; linux version
Use Ctrl-D to exit, Ctrl-E for paste mode
>>> import displayio, bitmaptools
>>> b = displayio.Bitmap(32, 32, 65536)
>>> bitmaptools.dither(b, b, displayio.Colorspace.RGB565)

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q re unneeded default values.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks for experimenting with testing with the Unix port, which will have advantages in the long run. Will wait for a clean build to merge, or you can if you see it first.

@dhalbert dhalbert merged commit b9ecb0f into adafruit:main Nov 12, 2021
@jepler
Copy link
Author

jepler commented Nov 12, 2021

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants