Skip to content

update frozen libraries, especially adafruit_hid #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2021
Merged

update frozen libraries, especially adafruit_hid #5587

merged 1 commit into from
Nov 17, 2021

Conversation

dhalbert
Copy link
Collaborator

See whether adafruit_hid still fits, with keyboard_layout_base.py now present.

@dhalbert dhalbert force-pushed the update-frozen-libs-2021-11 branch from a16c1b4 to 2e83e30 Compare November 16, 2021 00:19
@dhalbert dhalbert marked this pull request as ready for review November 16, 2021 01:55
@dhalbert
Copy link
Collaborator Author

dhalbert commented Nov 16, 2021 •
edited
Loading

Frozen libraries updated now, after a discussion with @Neradoc, to make sure that the new KeyboardLayoutBase code will fit on all boards when frozen. It does!

Anyone can review, thanks.

@dhalbert dhalbert requested review from kattni and tannewt November 17, 2021 00:22
kattni
kattni approved these changes Nov 17, 2021
View reviewed changes
Copy link

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kattni kattni merged commit a4be846 into adafruit:main Nov 17, 2021
@dhalbert dhalbert deleted the update-frozen-libs-2021-11 branch November 17, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @kattni