Skip to content

Switch CP to core 1 on S3 #5860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Switch CP to core 1 on S3 #5860

merged 1 commit into from
Jan 17, 2022

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jan 14, 2022

No description provided.

@tannewt tannewt added espressif applies to multiple Espressif chips esp32-s3 labels Jan 14, 2022
@tannewt tannewt added this to the 7.2.0 milestone Jan 14, 2022
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, to my limited understanding

@dhalbert dhalbert merged commit 3453ced into adafruit:main Jan 17, 2022
@dhalbert
Copy link
Collaborator

@tannewt The merge build for this failed on all the ESP32-S2 builds, not sure why if the original build worked:
https://github.com/adafruit/circuitpython/actions/runs/1709893707

/home/runner/work/circuitpython/circuitpython/.idf_tools/tools/xtensa-esp32s2-elf/esp-2021r2-8.4.0/xtensa-esp32s2-elf/bin/../lib/gcc/xtensa-esp32s2-elf/8.4.0/../../../../xtensa-esp32s2-elf/bin/ld: build-adafruit_feather_esp32s2/esp-idf/esp-idf/esp_phy/libesp_phy.a(phy_init.c.obj):(.literal.esp_phy_load_cal_and_init+0x18): undefined reference to `phy_bbpll_en_usb'
/home/runner/work/circuitpython/circuitpython/.idf_tools/tools/xtensa-esp32s2-elf/esp-2021r2-8.4.0/xtensa-esp32s2-elf/bin/../lib/gcc/xtensa-esp32s2-elf/8.4.0/../../../../xtensa-esp32s2-elf/bin/ld: build-adafruit_feather_esp32s2/esp-idf/esp-idf/esp_phy/libesp_phy.a(phy_init.c.obj): in function `esp_phy_load_cal_and_init':
/home/runner/work/circuitpython/circuitpython/ports/espressif/build-adafruit_feather_esp32s2/esp-idf/../../esp-idf/components/esp_phy/src/phy_init.c:626: undefined reference to `phy_bbpll_en_usb'
collect2: error: ld returned 1 exit status
make: *** [Makefile:407: build-adafruit_feather_esp32s2/firmware.elf] Error 1
make: Leaving directory '/home/runner/work/circuitpython/circuitpython/ports/espressif'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esp32-s3 espressif applies to multiple Espressif chips
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants