Skip to content

Fix esp32s3 devkitc uart naming and add board.UART #5905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2022

Conversation

prplz
Copy link

@prplz prplz commented Jan 22, 2022

The TX/RX pins were erroneously named TXD0/TXD1. I renamed them to TX/RX, also added board.UART.

Tested on n8r8 hardware

Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @prplz.

@microdev1 microdev1 merged commit 5ab16b7 into adafruit:main Jan 22, 2022
@microdev1 microdev1 added espressif applies to multiple Espressif chips board New board or update to a single board labels Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board New board or update to a single board espressif applies to multiple Espressif chips
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants