Only enable is31fl3741 for led glasses board #5955
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the description of #5584, the
is31fl3741
is supposed to only be enabled for the led glasses board. I found that it was mistakenly enabled by default on all nrf boards.Also fixed an uninitialized variable warning that prevents the module from building in debug mode. I don't actually know anything about this device and I just assumed the variable was supposed to start at zero. I don't own the led glasses board, so I was unable to test.
I confirmed the led glasses build still includes the is31fl3741 module, by inspection of the .map file and confirmed that another unrelated nrf board no longer contains the unneeded module.