Skip to content

Only enable is31fl3741 for led glasses board #5955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

prplz
Copy link

@prplz prplz commented Jan 31, 2022

From the description of #5584, the is31fl3741 is supposed to only be enabled for the led glasses board. I found that it was mistakenly enabled by default on all nrf boards.

Also fixed an uninitialized variable warning that prevents the module from building in debug mode. I don't actually know anything about this device and I just assumed the variable was supposed to start at zero. I don't own the led glasses board, so I was unable to test.

I confirmed the led glasses build still includes the is31fl3741 module, by inspection of the .map file and confirmed that another unrelated nrf board no longer contains the unneeded module.

Also fix a warning in is31fl3741
@dhalbert
Copy link
Collaborator

dhalbert commented Feb 1, 2022

@ladyada is this what you'd like: is31fl3741 enabled only on the glasses driver board?

@gamblor21
Copy link
Member

The missing initialization is fixed in #5726 which has a lot of changes to the whole structure of the is31fl3741 module. The PR is still waiting to be merged.

As to which boards it is enabled on I cannot remember the initial discussion but an product like https://www.adafruit.com/product/5201 can take advantage of this module as well.

At the time I submitted the first PR I had only been working on NRF boards so had not had the time to test it on other types of boards like ESP/RP2040/M4 (though it should work)

@ladyada
Copy link
Member

ladyada commented Feb 1, 2022

@dhalbert yep only on the led glasses

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @gamblor21, I will merge this for now, and we can still work on your PR.

@dhalbert dhalbert merged commit 0b26dba into adafruit:main Feb 1, 2022
@gamblor21
Copy link
Member

Thanks! @gamblor21, I will merge this for now, and we can still work on your PR.

Sounds good. I'll try to take a look later but it probably will not conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants