Correcting order of sideset parameters in function call #5984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we make the order be the same for the two routines? |
dhalbert
approved these changes
Feb 6, 2022
tannewt
reviewed
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5967 - PDMIn (and I2SOut) had the sideset enable parameter to common_hal_rp2pio_statemachine_construct() incorrectly positioned at the end of the parameter list. This would be where it goes if calling rp2pio_statemachine_construct(), but for common_hal_rp2pio_statemachine_construct() it needs to be just above the jmp_pin parameter. Tested the fix with a PDM mic using the script provided, and now correctly getting values.