Skip to content

RP2040 PDMIn frequency based on sample rate #5993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

DavePutz
Copy link
Collaborator

@DavePutz DavePutz commented Feb 8, 2022

Fix for issue #5914. Changed the frequency parameter to common_hal_rp2pio_statemachine_construct() for PDMIn on the RP2040 to use the sample rate instead of a fixed constant.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is exactly what I supplied for testing to @zapwizard (I think) via discord a while ago.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 114092d into adafruit:main Feb 8, 2022
@zapwizard
Copy link

Thanks, this will hopefully unlock ultrasonic PDM audio and open up a few new applications.
Do I need to wait for the nightly build to test this?

@dhalbert
Copy link
Collaborator

dhalbert commented Feb 8, 2022

There is no nightly: the build gets done as soon as the merge happens. Wait for a build with the commit hash 114092d or later, in https://adafruit-circuit-python.s3.amazonaws.com/index.html?prefix=bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants