Skip to content

Change reference of "libraries" to "classes #5994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2022
Merged

Change reference of "libraries" to "classes #5994

merged 1 commit into from
Feb 9, 2022

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Feb 8, 2022

Resolves #2095 by changing "libraries" to "classes"

tannewt
tannewt requested changes Feb 8, 2022
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you double check that this isn't written elsewhere? I suspect I copy and pasted this many places. Thanks!

@tekktrik
Copy link
Member Author

tekktrik commented Feb 8, 2022

Will do!

@tekktrik
Copy link
Member Author

tekktrik commented Feb 8, 2022

After a search, this was the only place in shared-bindings and shared-module that used "libraries" where it should have used "classes"!

@tekktrik tekktrik requested a review from tannewt February 8, 2022 23:33
tannewt
tannewt approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, that surprises me. Thanks for checking!

@tannewt tannewt merged commit 63188a8 into adafruit:main Feb 9, 2022
@tekktrik tekktrik deleted the doc/change-libraries-to-classes branch May 31, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove reference to "libraries", consider replacing with "classes"
2 participants
@tekktrik @tannewt