Add support for 9-bit mode to displayio.FourWire #6114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it with an RH-112 display, but something is still off, I will work on this further. |
|
The code works fine, just needed some additional parameters for the Display. |
tannewt
requested changes
Mar 4, 2022
|
Even if some platforms had support for 9-bit SPI, we would have to rearrange the bytes to insert the D/C bit anyways, so I see no advantage to using that. |
If the ``command`` pin is None, that information will instead be sent as a ninth bit in the SPI transactions. Fix adafruit#6109
tannewt
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
commandpin is None, that information will instead besent as a ninth bit in the SPI transactions.
Fix #6109
Note: I verified the code produces correct output, however, I can't test it with a real display until #6113 is fixed.