Skip to content

Fix supervisor.reload #6172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2022
Merged

Fix supervisor.reload #6172

merged 2 commits into from
Mar 17, 2022

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Mar 17, 2022

Fixes #6170

@tannewt tannewt added this to the 7.2.x milestone Mar 17, 2022
@tannewt tannewt requested a review from dhalbert March 17, 2022 17:39
dhalbert
dhalbert previously approved these changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Linux and macOS with Feather RP2040.

  • Copied 40k file to CIRCUITPY while running.
  • edited code.py.
  • wrote a code.py with a supervisor.reload(). Works as expected.
  • supervisor.reload() in the REPL does nothing (as expected, I would think).

All behavior is as expected. Thanks!

@tannewt tannewt merged commit 704a50a into adafruit:7.2.x Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@tannewt @dhalbert