Skip to content

Setup default BLE name in dotenv #6596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Conversation

Neradoc
Copy link

@Neradoc Neradoc commented Jul 14, 2022

Define the default BLE name of a board, for BLE workflow in particular (for example in a classroom setting).
This is only the default name, user code can later redefine the BLE name too.
Use CIRCUITPY_BLE_NAME in .env.

CIRCUITPY_BLE_NAME=Bill's Circuit Playground

IMG_1FB5CDEF906F-1

Neradoc added 2 commits July 14, 2022 11:55
Format:
CIRCUITPY_BLE_NAME = My BLE Board

- the length is limited to 31 characters
- for the NRF version it repeatedly truncates the name if it's too long
- the ESP version defaults to "nimble" if the name is too long
@tannewt tannewt self-requested a review July 14, 2022 18:07
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Code looks good. Please add documentation of this to docs/environment.rst.

@Neradoc
Copy link
Author

Neradoc commented Jul 14, 2022

Ah I knew I forgot something. Added CIRCUITPY_WEB_API_PASSWORD too. (In alphabetical order).

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 145cce9 into adafruit:main Jul 14, 2022
@Neradoc Neradoc deleted the ble-name-in-dotenv branch August 10, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants