Webflow edit page #6611
Merged
Webflow edit page #6611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tannewt
requested changes
Jul 25, 2022
# Conflicts: # supervisor/shared/web_workflow/web_workflow.c
|
#6608 includes a fix for the build that runs out of space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces: #6592
I tried getting the branch from that PR straightened out, but could not work it out. I started this one from an up-to-date main and didn't run into the same trouble with submodules on it.
One additional tweak in this version is specifying the quote_characters for jsmin in order to get it handle ES6 strings with backticks better. The
edit.jsfile makes use of this string syntax. https://pypi.org/project/jsmin/ mentions that it does not intend to support ES6, but does provide this argument if backtick strings are the specific thing causing trouble. I retested the edit page after this and it's back to working correctly to load and save files on the drive.