Skip to content

fix edit URL for files inside of directories #6680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

FoamyGuy
Copy link
Collaborator

@FoamyGuy FoamyGuy commented Aug 2, 2022

Fixes the URL for the edit link on directory pages in the web workflow to include the directory in the hash portion of the URL.

Resolves: #6671

Under current version the file /lib/adafruit_logging.py will end up with a url containing only #adafruit_logging.py

With this branch it will include the directory so it will be #/lib/adafruit_logging.py

@tannewt tannewt self-requested a review August 2, 2022 17:53
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit cb2e1e0 into adafruit:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Workflow file browser edit function doesn't work in folders
2 participants