Skip to content

Couple Minor Fixes #6974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2022
Merged

Couple Minor Fixes #6974

merged 3 commits into from
Oct 1, 2022

Conversation

microdev1
Copy link
Collaborator

No description provided.

dhalbert
dhalbert requested changes Sep 30, 2022
View reviewed changes
@microdev1 microdev1 requested a review from dhalbert October 1, 2022 03:46
@dhalbert
Copy link
Collaborator

dhalbert commented Oct 1, 2022

I pushed a new commit that removed a bunch of redundant port/*/.gitignore files, and removed some stale entries from others. Also ports/unix/.gitignore was ignoring *.py files, but now there are some in variants/. I did a unix build to check that no build-time *.py were created

dhalbert
dhalbert approved these changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing these!

@dhalbert dhalbert merged commit ad79f59 into adafruit:main Oct 1, 2022
@microdev1 microdev1 deleted the patch branch October 1, 2022 17:59
@Neradoc Neradoc mentioned this pull request Nov 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler left review comments

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@microdev1 @dhalbert @jepler