Skip to content

Implement certain supervisor functions as properties #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2022
Merged

Implement certain supervisor functions as properties #6980

merged 2 commits into from
Oct 4, 2022

Conversation

microdev1
Copy link
Collaborator

Implements the following as supervisor.runtime properties:

  • disable_ble_workflow
  • set_next_stack_limit
  • set_rgb_status_brightness

@microdev1
implement certain supervisor functions as properties
17ed2a6 
- disable_ble_workflow
- set_next_stack_limit
- set_rgb_status_brightness
@microdev1 microdev1 linked an issue Oct 1, 2022 that may be closed by this pull request
Implement certain functions in supervisor as properties #5414
Closed
dhalbert
dhalbert requested changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor idea. You may demur.

@microdev1 @dhalbert
implement suggested change
4fd15ac 
pass brightness value directly

Co-authored-by: Dan Halbert <[email protected]>
@microdev1 microdev1 requested a review from dhalbert October 4, 2022 02:58
dhalbert
dhalbert approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dhalbert dhalbert merged commit 1c2d2c9 into adafruit:main Oct 4, 2022
@microdev1 microdev1 deleted the supervisor branch October 14, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
circuitpython api enhancement supervisor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement certain functions in supervisor as properties
2 participants
@microdev1 @dhalbert