Skip to content

Fix espressif log level #7052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Fix espressif log level #7052

merged 1 commit into from
Oct 14, 2022

Conversation

microdev1
Copy link
Collaborator

I believe our log level customization was lost somewhere along the way and went unnoticed.
This saves ~90K 🤯 on microS2.

@microdev1 microdev1 added the espressif applies to multiple Espressif chips label Oct 14, 2022
@bill88t
Copy link

bill88t commented Oct 14, 2022

For waveshare_esp32s2_pico

Building main results to:

1390736 bytes used,   51056 bytes free in flash firmware space out of 1441792 bytes (1408.0kB).
     92 bytes used,    8100 bytes free in 'RTC Fast Memory' out of 8192 bytes (8.0kB).
   4112 bytes used,    4080 bytes free in 'RTC Slow Memory' out of 8192 bytes (8.0kB).
      0 bytes used,   32768 bytes free in 'Internal SRAM 0' out of 32768 bytes (32.0kB).
 244743 bytes used,   50169 bytes free in 'Internal SRAM 1' out of 294912 bytes (288.0kB).

And ram usages in ljinux as:

System Memory: 54KiB / 8003KiB
ESPIDF Memory: 33KiB / 144KiB

Meanwhile this pr:

1294528 bytes used,  147264 bytes free in flash firmware space out of 1441792 bytes (1408.0kB).
     92 bytes used,    8100 bytes free in 'RTC Fast Memory' out of 8192 bytes (8.0kB).
   4112 bytes used,    4080 bytes free in 'RTC Slow Memory' out of 8192 bytes (8.0kB).
      0 bytes used,   32768 bytes free in 'Internal SRAM 0' out of 32768 bytes (32.0kB).
 241119 bytes used,   53793 bytes free in 'Internal SRAM 1' out of 294912 bytes (288.0kB).

And:

System Memory: 54KiB / 8003KiB
ESPIDF Memory: 33KiB / 146KiB

Not sure as to why espidf mem changed but fine.
These builds were conducted locally and work just fine.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this. Might this explain the ESP-IDF v5.0 growth as well, if they added a lot of logging??

@dhalbert dhalbert merged commit 25e9985 into adafruit:main Oct 14, 2022
@microdev1 microdev1 deleted the espressif branch October 14, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
espressif applies to multiple Espressif chips
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants