Skip to content

Ci set matrix improvements #7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 14, 2022
Merged

Conversation

jepler
Copy link

@jepler jepler commented Oct 14, 2022

This runs faster, is more correct (I hope!) and is easier to test locally. Closes #6922

Frozen modules:

$ GITHUB_OUTPUT=/dev/null ./tools/ci_set_matrix.py  frozen/Adafruit_CircuitPython_MIDI 
Using files list on commandline
Adding docs/boards to build based on changed files
Building docs: False
Building boards:
  zrichard_rp2.65-f

Port-specific changes to shared modules:

$ GITHUB_OUTPUT=/dev/null ./tools/ci_set_matrix.py  ports/raspberrypi/common-hal/ssl/SSLSocket.c 
Using files list on commandline
Adding docs/boards to build based on changed files
Building docs: False
Building boards:
  raspberry_pi_pico_w

Changes to port-specific modules:

$ GITHUB_OUTPUT=/dev/null ./tools/ci_set_matrix.py  ports/raspberrypi/bindings/cyw43/__init__.c
Using files list on commandline
Adding docs/boards to build based on changed files
Building docs: True
Building boards:
  raspberry_pi_pico_w

@jepler jepler requested a review from dhalbert October 14, 2022 16:32
Now you can e.g., `tools/ci_set_matrix.py ports/raspberrypi/mpconfigport.h`
and see what outputs would be set.
This looks modestly expensive, and it's trivial to cache it.
This reduces the _elapsed_ time running the script from ~90s to ~15s
on my AMD Ryzen 7 5700U. The CPU time is still around 2 minutes.
.. when the file is within ports, just get the settings for boards
within the port
@jepler jepler force-pushed the ci-set-matrix-improvements branch from 357aa20 to d08b43f Compare October 14, 2022 16:33
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this good cleanup!

@dhalbert dhalbert merged commit 496057e into adafruit:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port-only change made all boards build
2 participants