Skip to content

Use micropython #defines for stream polling operations #7058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

jepler
Copy link

@jepler jepler commented Oct 14, 2022

We adopted the file "py/ioctl.h" and the ioctl names beginning with MP_IOCTL_POLL while micropython went with "py/stream.h" and MP_STREAM_POLL.

Align with upstream.

Closes #6711

We adopted the file "py/ioctl.h" and the ioctl names beginning
with MP_IOCTL_POLL while micropython went with "py/stream.h" and
MP_STREAM_POLL.

Align with upstream.

Closes adafruit#6711
@jepler jepler requested a review from dhalbert October 14, 2022 17:16
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py/ioctl.h went in way back here:
1598e44

@dhalbert dhalbert merged commit 747e9f9 into adafruit:main Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check MP_STREAM_POLL vs MP_IOCTL_POLL
2 participants