Fix 2/4MB Partition Tables & Makefile #7073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove log level: set by -opt or -debug sdkconfig - remove lwip hostname: set by board specific sdkconfig
dhalbert
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change: ESP32/ESP32C3 boards having 4MB flash will loose CIRCUITPY data post f86377e
Fixes in this PR:
otapartitions in4MB-no-uf2partition table.2MB-no-uf2partition table to2MB-no-ota-no-uf2as it is too small for ota support.UF2_BOOTLOADERcondition in Makefile now depends onCIRCUITPY_USBinstead ofIDF_TARGET.Fixes #7070. Thanks @dhalbert for finding the bug in partition table.