Skip to content

Update espressif build configuration #7094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2022
Merged

Update espressif build configuration #7094

merged 2 commits into from
Oct 21, 2022

Conversation

microdev1
Copy link
Collaborator

This PR includes:

  1. 2285dd1 Update espressif risc-v build configuration:
    1. Use optimization level O2 for now.
    2. Explicitly state risc-v arch: Fixes ESP32-C3 boot-loops with CP 8.0.0-beta.2  #7060.
  2. 0d281ed Re-organize espressif mpconfigport.mk.

@microdev1
update espressif risc-v build configuration
2285dd1 
- use optimization level O2
- explicitly state risc-v arch
@microdev1
reorganize espressif mpconfigport.mk
5b2728b
@microdev1 microdev1 added bug enhancement espressif applies to multiple Espressif chips labels Oct 21, 2022
dhalbert
dhalbert reviewed Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you came to similar conclusions in a different way. The arch difference is the most mysterious. Happy to approve after I hear your feedback.

@dhalbert dhalbert mentioned this pull request Oct 21, 2022
Closed
dhalbert
dhalbert approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on QT Py ESP32-C3. Thank you for figuring out the arch change issue!

@dhalbert dhalbert merged commit 18e70ff into adafruit:main Oct 21, 2022
@dhalbert dhalbert mentioned this pull request Oct 21, 2022
Closed
@microdev1 microdev1 deleted the espressif branch October 21, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler left review comments

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
bug enhancement espressif applies to multiple Espressif chips
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESP32-C3 boot-loops with CP 8.0.0-beta.2
3 participants
@microdev1 @jepler @dhalbert