Skip to content

Esp32 dev kit v1 #7258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 24, 2022
Merged

Esp32 dev kit v1 #7258

merged 6 commits into from
Dec 24, 2022

Conversation

m1cha1s
Copy link

@m1cha1s m1cha1s commented Nov 25, 2022

Added board definition for ESP32 devkit v1 board.

@DerBroader71
Copy link

Is there any chance to be more specific over which make/model board this is, as there are 3 version of the ESP32 Devkit V1 that I have come across - 30/36 and 38 pin?

@tannewt
Copy link
Member

tannewt commented Nov 28, 2022

I don't think you should be adding an uncrustify.cfg file. Please remove it from the PR.

@tannewt tannewt added board New board or update to a single board esp32 labels Nov 29, 2022
@m1cha1s
Copy link
Author

m1cha1s commented Nov 30, 2022

@DerBroader71 The board definition is for the board that looks like the one on this image. @tannewt removed the uncrustify.cfg file.

@dhalbert
Copy link
Collaborator

@m1cha1s You were using URL links instead of @ references to tag people. Did you mean to do that? I edited the previous post to change them to @ references.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add doit_ to the start of the board name (its folder) because that is the manufacturer.

@m1cha1s
Copy link
Author

m1cha1s commented Nov 30, 2022

@tannewt I've changed the name. @dhalbert thx for the fix :).

tannewt
tannewt previously requested changes Dec 1, 2022
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to delete the files for the old name (using git rm).

@Anutrix
Copy link

Anutrix commented Dec 24, 2022

Any updates on this?

@m1cha1s
Copy link
Author

m1cha1s commented Dec 24, 2022

@Anutrix everything should be fixed. The review is the only thing that needs to be done for it to be merged I believe.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK! Merging.

@dhalbert dhalbert merged commit 88d0eba into adafruit:main Dec 24, 2022
@dhalbert
Copy link
Collaborator

dhalbert commented Dec 24, 2022

Thanks! Please make a PR to circuitpython-org if you have not already done so.

@VictorioBerra
Copy link

Should I be able to find this on the downloads page here https://circuitpython.org/downloads ?

Can someone tell me where I can download the Firmware?

@microdev1
Copy link
Collaborator

Should I be able to find this on the downloads page here https://circuitpython.org/downloads ?

Can someone tell me where I can download the Firmware?

Yes, you can search for it in the downloads page. A direct link: https://circuitpython.org/board/doit_esp32_devkit_v1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board New board or update to a single board esp32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants