-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Esp32 dev kit v1 #7258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Esp32 dev kit v1 #7258
Conversation
Is there any chance to be more specific over which make/model board this is, as there are 3 version of the ESP32 Devkit V1 that I have come across - 30/36 and 38 pin? |
I don't think you should be adding an |
@DerBroader71 The board definition is for the board that looks like the one on this image. @tannewt removed the uncrustify.cfg file. |
@m1cha1s You were using URL links instead of @ references to tag people. Did you mean to do that? I edited the previous post to change them to @ references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add doit_
to the start of the board name (its folder) because that is the manufacturer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to delete the files for the old name (using git rm
).
Any updates on this? |
@Anutrix everything should be fixed. The review is the only thing that needs to be done for it to be merged I believe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK! Merging.
Thanks! Please make a PR to circuitpython-org if you have not already done so. |
Should I be able to find this on the downloads page here https://circuitpython.org/downloads ? Can someone tell me where I can download the Firmware? |
Yes, you can search for it in the downloads page. A direct link: https://circuitpython.org/board/doit_esp32_devkit_v1/ |
Added board definition for ESP32 devkit v1 board.