Add function for drawing polygons to bitmaptools #7471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
reviewed
Jan 21, 2023
There was a problem hiding this comment.
Awesome! Thanks for working on this @matemaciek!
I tried this out successfully, but do have a suggestion about possibly changing the types of the arguments used for the points. Let me know your thoughts on switching that to a list or a tuple (or perhaps a list of tuples) instead of using the bytes buffer types.
FoamyGuy
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
I updated this with 2 small changes:
- changed the int docstring type to ReadableBuffer
- added a basic example of usage of the function
It seems good to me at this point (pending actions result). Allowing lists or tuples for the points would be a "nice to have" imo, but doesn't need to hold this back.
I retested the latest version on a Feather ESP32-S2 TFT with the example code that was added to the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @FoamyGuy (-: