Skip to content

Tweak the UART in use message on RP2040 #7605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2023
Merged

Tweak the UART in use message on RP2040 #7605

merged 1 commit into from
Feb 18, 2023

Conversation

Neradoc
Copy link

@Neradoc Neradoc commented Feb 17, 2023

The message All UART peripherals are in use was incorrect, since it would be shown when reusing the same peripheral while the other was free. SPI and I2C also only say "peripheral in use".

@microdev1
Copy link
Collaborator

@jepler @dhalbert What do you think about converting peripheral in use messages to a common function with QSTR.

microdev1
microdev1 approved these changes Feb 18, 2023
View reviewed changes
Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Neradoc.

@microdev1 microdev1 merged commit 508f201 into adafruit:main Feb 18, 2023
@dhalbert
Copy link
Collaborator

@jepler @dhalbert What do you think about converting peripheral in use messages to a common function with QSTR.

If it can be refactored, that would be great, like the pin message refactorings.

@Neradoc Neradoc deleted the pico-uart-in-use-error branch March 19, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microdev1 microdev1 microdev1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neradoc @microdev1 @dhalbert