remove abs() from radius #7890
Merged
remove abs() from radius #7890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvc0
approved these changes
Apr 21, 2023
| int16_t radius = abs(self->radius); | ||
| int16_t radius = self->radius; |
There was a problem hiding this comment.
This is the only thing I'd currently advocate for changing in here. This change looks great to me, thanks 😄
You could use the value as-is instead of the typecast it's doing to a signed integer but no big deal either way imo:
Suggested change
| int16_t radius = abs(self->radius); | |
| int16_t radius = self->radius; | |
| uint16_t radius = self->radius; |
dhalbert
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to resolve #7883
This removes the unnecessary absolute value call from radius variable.
Honestly I don't quite follow the rest of the conversation about x and y calculations and casting. If there are other proposed changes that need to be tested out I'm happy to try those if someone can point me more specifically to what the code would look like.