Test empty settings.toml #8144
Merged
Test empty settings.toml #8144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. because the first test is actually accepted on python 3.10 and newer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tannewt wondered if this could be a cause of instability. Many boards in the wild are probably running with an empty settings.toml, since formatting the CIRCUITPY drive creates one
but it also wouldn't hurt to add a test for it in the core tests.
This also adds an expected-result file for the test basics/string_format_error, because the behavior of the test under python 3.11.2 (debian bookworm) differs from 3.9. CP follows the 3.9 behavior. This allows the testsuite to pass on the new stable debian.