[Fix] Mis-use of cache for STM32 #8228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7615
Perhaps i mis-understood something on the code + i dont have any hardware to test this with, please review it throughtfully.
From my understanding:
-
num_blocks: amount of memory we want to read-
count: amount of memory we can read from cacheIf that is correct (bold assumption):
-
<should have been<=. That is, reading the same or less amount of memory than there's in cache- Why would we use
MINoncountthere at all? Since the variable isnt used later on,MIN+<is effectively just a convoluted way of checking which value was higher, i believe...PS: I dont know which branch i should target, just went for main but let me know if i use go against another one.