Cache configuration descriptor #8254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use it to open endpoints as they are used. Fetching the descriptor as needed can cause issues with devices that we're expecting a control packet while another transaction was ongoing. Specifically, a usb thumb drive didn't expect a control transaction while doing a SCSI transaction. This PR also aborts transactions on timeout or ctrl-c interrupt. It doesn't always recover though...
|
The failure here is due to a change of mine; the fix is now part of #8252, so this PR will need to be updated with the latest changes once that one's been merged. |
|
I tried to update this PR by merging main into it, but github denied my attempt to push the result to tannewt's fork even though it says "maintainers are allowed to edit this pull request". 🤷 |
|
Scott had to give me extra permissions to do that. I think it's because it's forked from |
|
@jepler I sent you an invite to collaborate on my fork. Thanks for trying to update it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use it to open endpoints as they are used. Fetching the descriptor as needed can cause issues with devices that we're expecting a control packet while another transaction was ongoing. Specifically, a usb thumb drive didn't expect a control transaction while doing a SCSI transaction.
This PR also aborts transactions on timeout or ctrl-c interrupt. It doesn't always recover though...