Skip to content

[ESPCAMERA] Deinit all the pins. #8388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2023
Merged

[ESPCAMERA] Deinit all the pins. #8388

merged 1 commit into from
Sep 12, 2023

Conversation

bill88t
Copy link

@bill88t bill88t commented Sep 11, 2023

What the title says.
Without this, if you deinit your camera object, you have to reload to be able to use the pins.

jepler
jepler previously approved these changes Sep 12, 2023
View reviewed changes
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. thanks. I don't know why I didn't also encounter this.

@dhalbert
Copy link
Collaborator

Is this worth rebasing to be on 8.2.x before you merge?

@dhalbert dhalbert changed the base branch from main to 8.2.x September 12, 2023 16:51
@dhalbert dhalbert dismissed jepler’s stale review September 12, 2023 16:51

The base branch was changed.

@dhalbert dhalbert changed the base branch from 8.2.x to main September 12, 2023 16:52
dhalbert
dhalbert approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried rebasing to 8.2.x but I got a zillion commit changes. So it will need manual backporting if it's worth doing that.

@dhalbert dhalbert merged commit 843fca1 into adafruit:main Sep 12, 2023
@bill88t
Copy link
Author

bill88t commented Sep 12, 2023

I will manually cherrypick it in a new pr in a bit.

@bill88t bill88t deleted the espcam-deinit branch September 13, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@jepler jepler jepler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bill88t @dhalbert @jepler