sort targetgroup attrs (kubernetes-sigs#1971)

kishorj · Timothy-Dougherty · commit 3a2b453e6f01 · 2023-11-09T11:28:40.000+11:00
diff --git a/pkg/service/model_build_target_group.go b/pkg/service/model_build_target_group.go
@@ -16,6 +16,7 @@ import (
 	"sigs.k8s.io/aws-load-balancer-controller/pkg/annotations"
 	"sigs.k8s.io/aws-load-balancer-controller/pkg/k8s"
 	elbv2model "sigs.k8s.io/aws-load-balancer-controller/pkg/model/elbv2"
+	"sort"
 	"strconv"
 	"strings"
 )
@@ -216,6 +217,9 @@ func (t *defaultModelBuildTask) buildTargetGroupAttributes(_ context.Context) ([
 			Value: attrValue,
 		})
 	}
+	sort.Slice(attributes, func(i, j int) bool {
+		return attributes[i].Key < attributes[j].Key
+	})
 	return attributes, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ import (`
`16`	`16`	`"sigs.k8s.io/aws-load-balancer-controller/pkg/annotations"`
`17`	`17`	`"sigs.k8s.io/aws-load-balancer-controller/pkg/k8s"`
`18`	`18`	`elbv2model "sigs.k8s.io/aws-load-balancer-controller/pkg/model/elbv2"`
	`19`	`+ "sort"`
`19`	`20`	`"strconv"`
`20`	`21`	`"strings"`
`21`	`22`	`)`
`@@ -216,6 +217,9 @@ func (t *defaultModelBuildTask) buildTargetGroupAttributes(_ context.Context) ([`
`216`	`217`	`Value: attrValue,`
`217`	`218`	`})`
`218`	`219`	`}`
	`220`	`+ sort.Slice(attributes, func(i, j int) bool {`
	`221`	`+ return attributes[i].Key < attributes[j].Key`
	`222`	`+ })`
`219`	`223`	`return attributes, nil`
`220`	`224`	`}`
`221`	`225`