resolve VPC CIDRs for UDP protocol (kubernetes-sigs#2008)

kishorj · Timothy-Dougherty · commit 7a75ce9a9e1e · 2023-11-09T11:28:40.000+11:00
diff --git a/pkg/service/model_build_target_group.go b/pkg/service/model_build_target_group.go
@@ -369,7 +369,7 @@ func (t *defaultModelBuildTask) buildTargetGroupBindingSpec(ctx context.Context,
 		targetPort = intstr.FromInt(int(port.NodePort))
 	}
 	defaultSourceRanges := []string{"0.0.0.0/0"}
-	if preserveClientIP && scheme == elbv2model.LoadBalancerSchemeInternal {
+	if (port.Protocol == corev1.ProtocolUDP || preserveClientIP) && scheme == elbv2model.LoadBalancerSchemeInternal {
 		defaultSourceRanges, err = t.vpcResolver.ResolveCIDRs(ctx)
 		if err != nil {
 			return elbv2model.TargetGroupBindingResourceSpec{}, err

Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ func (t *defaultModelBuildTask) buildTargetGroupBindingSpec(ctx context.Context,`
`369`	`369`	`targetPort = intstr.FromInt(int(port.NodePort))`
`370`	`370`	`}`
`371`	`371`	`defaultSourceRanges := []string{"0.0.0.0/0"}`
`372`		`- if preserveClientIP && scheme == elbv2model.LoadBalancerSchemeInternal {`
	`372`	`+ if (port.Protocol == corev1.ProtocolUDP \|\| preserveClientIP) && scheme == elbv2model.LoadBalancerSchemeInternal {`
`373`	`373`	`defaultSourceRanges, err = t.vpcResolver.ResolveCIDRs(ctx)`
`374`	`374`	`if err != nil {`
`375`	`375`	`return elbv2model.TargetGroupBindingResourceSpec{}, err`