Remove calls to FileHandle.synchronizeFile().

allevato · allevato · commit fda8b5c66d71 · 2020-04-02T09:52:33.000-07:00
Standard output does not support `fsync`, which is the system
call that this boils down to on Linux (and presumably on Darwin
as well). In both cases, `fsync` sets `errno` to `EINVAL`, but
unfortunately Foundation's behavior differs per platform: on
Darwin the error is silently swallowed, but on Linux it traps.
diff --git a/Sources/swift-format/Subcommands/Format.swift b/Sources/swift-format/Subcommands/Format.swift
@@ -108,7 +108,6 @@ private func formatMain(
       try bufferData.write(to: assumingFileURL, options: .atomic)
     } else {
       try formatter.format(source: source, assumingFileURL: assumingFileURL, to: &stdoutStream)
-      stdoutStream.synchronizeFile()
     }
   } catch SwiftFormatError.fileNotReadable {
     diagnosticEngine.diagnose(
@@ -122,7 +121,6 @@ private func formatMain(
         return
       }
       stdoutStream.write(source)
-      stdoutStream.synchronizeFile()
       return
     }
     let location = SourceLocationConverter(file: path, source: source).location(for: position)

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,6 @@ private func formatMain(`
`108`	`108`	`try bufferData.write(to: assumingFileURL, options: .atomic)`
`109`	`109`	`} else {`
`110`	`110`	`try formatter.format(source: source, assumingFileURL: assumingFileURL, to: &stdoutStream)`
`111`		`- stdoutStream.synchronizeFile()`
`112`	`111`	`}`
`113`	`112`	`} catch SwiftFormatError.fileNotReadable {`
`114`	`113`	`diagnosticEngine.diagnose(`
`@@ -122,7 +121,6 @@ private func formatMain(`
`122`	`121`	`return`
`123`	`122`	`}`
`124`	`123`	`stdoutStream.write(source)`
`125`		`- stdoutStream.synchronizeFile()`
`126`	`124`	`return`
`127`	`125`	`}`
`128`	`126`	`let location = SourceLocationConverter(file: path, source: source).location(for: position)`