Merge pull request scala#5297 from retronym/review/5268

retronym · web-flow · commit 4bc9ca51a4b0 · 2016-07-26T09:19:15.000+02:00
Disable stub warning by default.
diff --git a/src/compiler/scala/tools/nsc/symtab/classfile/ClassfileParser.scala b/src/compiler/scala/tools/nsc/symtab/classfile/ClassfileParser.scala
@@ -366,7 +366,7 @@ abstract class ClassfileParser {
       //   - better owner than `NoSymbol`
       //   - remove eager warning
       val msg = s"Class $name not found - continuing with a stub."
-      if (!settings.isScaladoc) warning(msg)
+      if ((!settings.isScaladoc) && (settings.verbose || settings.developer)) warning(msg)
       return NoSymbol.newStubSymbol(name.toTypeName, msg)
     }
     val completer     = new loaders.ClassfileLoader(file)
diff --git a/test/files/run/t7439.check b/test/files/run/t7439.check
@@ -1,2 +1,2 @@
 Recompiling after deleting t7439-run.obj/A_1.class
-pos: NoPosition Class A_1 not found - continuing with a stub. WARNING
+
diff --git a/test/files/run/t8442.check b/test/files/run/t8442.check
@@ -1 +1 @@
-pos: NoPosition Class A_1 not found - continuing with a stub. WARNING
+
diff --git a/test/files/run/t9268.check b/test/files/run/t9268.check
@@ -1,5 +1,4 @@
 Compiling Client1
-pos: NoPosition Class Waiter not found - continuing with a stub. WARNING
+
 Compiling Client2
-pos: NoPosition Class Waiter not found - continuing with a stub. WARNING
 pos: NoPosition Unable to locate class corresponding to inner class entry for Predicate in owner Waiter ERROR

Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@ abstract class ClassfileParser {`
`366`	`366`	// - better owner than `NoSymbol`
`367`	`367`	`// - remove eager warning`
`368`	`368`	`val msg = s"Class $name not found - continuing with a stub."`
`369`		`- if (!settings.isScaladoc) warning(msg)`
	`369`	`+ if ((!settings.isScaladoc) && (settings.verbose \|\| settings.developer)) warning(msg)`
`370`	`370`	`return NoSymbol.newStubSymbol(name.toTypeName, msg)`
`371`	`371`	`}`
`372`	`372`	`val completer = new loaders.ClassfileLoader(file)`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`Recompiling after deleting t7439-run.obj/A_1.class`
`2`		`-pos: NoPosition Class A_1 not found - continuing with a stub. WARNING`
	`2`	`+`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-pos: NoPosition Class A_1 not found - continuing with a stub. WARNING`
	`1`	`+`