TODO: static forwarders

object Properties extends PropertiesTrait

trait PropertiesTrait {
  // the protected member is not emitted as a static member of  -- it works when dropping the access modifier
  // somehow, the module class member is considered deferred in BForwardersGen
  protected val propFilename: String = /
}

// [log jvm] No forwarder for 'getter propFilename' from Properties to 'module class Properties': false || m.isDeferred == true || false || false

// the following method is missing compared to scalac
// public final class Properties {
//     public static String propFilename() {
//         return Properties$.MODULE$.propFilename();
//     }

Author: adriaanm

src/compiler/scala/tools/nsc/backend/jvm/BCodeHelpers.scala

@@ -632,7 +632,7 @@ abstract class BCodeHelpers extends BCodeIdiomatic with BytecodeWriters {
 
       for (m <- moduleClass.info.membersBasedOnFlags(bCodeAsmCommon.ExcludedForwarderFlags, symtab.Flags.METHOD)) {
         if (m.isType || m.isDeferred || (m.owner eq definitions.ObjectClass) || m.isConstructor)
-          debuglog(s"No forwarder for '$m' from $jclassName to '$moduleClass'")
+          debuglog(s"No forwarder for '$m' from $jclassName to '$moduleClass': ${m.isType} || ${m.isDeferred} || ${m.owner eq definitions.ObjectClass} || ${m.isConstructor}")
         else if (conflictingNames(m.name))
           log(s"No forwarder for $m due to conflict with ${linkedClass.info.member(m.name)}")
         else if (m.hasAccessBoundary)

src/compiler/scala/tools/nsc/transform/Fields.scala

@@ -120,26 +120,26 @@ abstract class Fields extends InfoTransform with ast.TreeDSL with TypingTransfor
         // strict, memoized accessors will receive an implementation in first real class to extend this trait
         decls.foreach {
           case accessor if accessor hasFlag ACCESSOR =>
-            // only affects private symbols, with a destructive update of their name, also sets flags
-            // required for private vals in traits
-            accessor.makeNotPrivate(clazz)
-
             if (!(accessor hasFlag (DEFERRED | LAZY)) && fieldMemoizationIn(accessor, clazz).needsField) {
               // in a trait, a memoized accessor becomes deferred
               // (it'll receive an implementation in the first real class to extend this trait)
 
               // can't mark getter as FINAL in trait, but remember for when we synthetisize the impl in the subclass to make it FINAL
               val finality = if (accessor hasFlag FINAL) FINAL_TRAIT_ACCESSOR else 0
-              accessor setFlag (finality | lateFINAL | DEFERRED | SYNTHESIZE_IMPL_IN_SUBCLASS)
-
-              // trait members cannot be final (but the synthesized ones should be)
-              // LOCAL no longer applies (already made not-private)
-              accessor resetFlag (FINAL | LOCAL)
+              accessor setFlag (finality | DEFERRED | SYNTHESIZE_IMPL_IN_SUBCLASS)
 
               if ((accessor hasFlag STABLE) && accessor.isGetter) // TODO: isGetter is probably redundant?
                 newSetters += newTraitSetter(accessor, clazz)
             }
 
+            // only affects private symbols, with a destructive update of their name, also sets flags
+            // required for private vals in traits
+            accessor.makeNotPrivate(clazz)
+
+            // trait members cannot be final (but the synthesized ones should be)
+            // LOCAL no longer applies (already made not-private)
+            accessor resetFlag (FINAL | LOCAL)
+
           case _ =>
         }
 

src/compiler/scala/tools/nsc/transform/LambdaLift.scala

@@ -451,7 +451,7 @@ abstract class LambdaLift extends InfoTransform {
            // See neg/t1909-object.scala
            def msg = s"SI-1909 Unable to STATICally lift $sym, which is defined in the self- or super-constructor call of ${sym.owner.owner}. A VerifyError is likely."
            devWarning(tree.pos, msg)
-          } else sym setFlag STATIC
+         } else sym setFlag STATIC
       }
 
       sym.owner = sym.owner.enclClass