Skip to content

Commit f9ca686

Browse files
committed
readme/contributor's guide tweaks
based on feedback from lrytz
1 parent 80e98b0 commit f9ca686

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

CONTRIBUTING.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,18 +49,11 @@ A new language feature requires a SIP (Scala Improvement Process) proposal. For
4949
Here is some advice on how to craft a pull request with the best possible
5050
chance of being accepted.
5151

52-
### Merging
53-
54-
A pull request should merge cleanly. (If enough time passes after
55-
your initial submission, we may ask you to rebase it onto the current
56-
mainline code.)
57-
5852
### Tests
5953

6054
Bug fixes should include regression tests -- in the same commit as the fix.
6155

6256
If testing isn't feasible, the commit message should explain why.
63-
(Consider discussing on scala-internals first.)
6457

6558
New features and enhancements must be supported by a respectable test suite.
6659

@@ -137,5 +130,3 @@ A reviewer gives the green light by commenting "LGTM" (looks good to me).
137130
A review feedback may be addressed by pushing new commits to the request, if these commits stand on their own.
138131

139132
Once all these conditions are met, and we agree with the change (we are available on scala-internals to discuss this beforehand, before you put in the coding work!), we will merge your changes.
140-
141-
Please note: you are responsible for meeting these criteria (reminding your reviewer, for example).

README.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,20 +25,18 @@ If you need some help with your PR at any time, please feel free to @-mention an
2525

2626
additional reviewer suggestions:
2727

28-
* library: @phaller (Philipp Haller), @axel22 (Aleksander Prokopec -- concurrent & collection)
28+
* library: @axel22 (Aleksander Prokopec -- concurrent & collection)
2929
* specialisation: @axel22 (Aleksander Prokopec), @vladureche (Vlad Ureche), @dragos (Iulian Dragos)
3030
* named / default args, annotations, plugins: @lrytz (Lukas Rytz)
31-
* macros, reflection, manifests, string interpolation: @xeno-by (Eugene Burmako), @cvogt (Christopher Vogt)
32-
* type checker, inference: @odersky (Martin Odersky), @adriaanm (Adriaan Moors)
33-
* language specification, value classes: @odersky (Martin Odersky)
31+
* macros, reflection, manifests, string interpolation: @xeno-by (Eugene Burmako)
32+
* type checker, inference: @adriaanm (Adriaan Moors)
33+
* language specification: @adriaanm (Adriaan Moors)
3434
* new pattern matcher, implicit search: @adriaanm (Adriaan Moors)
35-
* partest: @phaller (Philipp Haller)
36-
* error handling, lazy vals: @hubertp (Hubert Plociniczak)
3735
* backend: @lrytz (Lukas Rytz), @retronym (Jason Zaugg), @dragos (Iulian Dragos)
3836
* repl, compiler performance: @retronym (Jason Zaugg)
3937
* scaladoc: @dickwall (Dick Wall), @vladureche (Vlad Ureche)
4038
* optimizer: @vladureche (Vlad Ureche), @lrytz (Lukas Rytz)
41-
* build: @jsuereth (Josh Suereth)
39+
* build: @SethTisue
4240
* random compiler bugs: @retronym, @lrytz, @adriaanm
4341
* documentation: @heathermiller (Heather Miller), @dickwall (Dick Wall)
4442

0 commit comments

Comments
 (0)