Skip to content

Commit ffa1fb9

Browse files
DavidSpickettadrian-prantl
authored andcommitted
[lldb][test] Enable TestDAP_runInTerminal on non-x86 architectures (llvm#111543)
I don't see an obvious reason it has to be x86 specific and local testing on Arm and AArch64 is fine. Originally disabled in 50337fb in response to failures apparently caused by https://reviews.llvm.org/D93951. Perhaps those still exist but worth trying this and checking I think. (cherry picked from commit de4f2c9)
1 parent 3610511 commit ffa1fb9

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

lldb/test/API/tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ def isTestSupported(self):
4545

4646
@skipIfLinux # FIXME: doesn't seem to work on Ubuntu 16.04.
4747
@skipIfWindows
48-
@skipIf(archs=no_match(["x86_64"]))
4948
def test_runInTerminal(self):
5049
if not self.isTestSupported():
5150
return
@@ -91,7 +90,6 @@ def test_runInTerminal(self):
9190
env = self.dap_server.request_evaluate("foo")["body"]["result"]
9291
self.assertIn("bar", env)
9392

94-
@skipIf(archs=no_match(["x86_64"]))
9593
def test_runInTerminalWithObjectEnv(self):
9694
if not self.isTestSupported():
9795
return
@@ -116,7 +114,6 @@ def test_runInTerminalWithObjectEnv(self):
116114

117115
@skipIfLinux # FIXME: doesn't seem to work on Ubuntu 16.04.
118116
@skipIfWindows
119-
@skipIf(archs=no_match(["x86_64"]))
120117
def test_runInTerminalInvalidTarget(self):
121118
if not self.isTestSupported():
122119
return
@@ -136,7 +133,6 @@ def test_runInTerminalInvalidTarget(self):
136133

137134
@skipIfLinux # FIXME: doesn't seem to work on Ubuntu 16.04.
138135
@skipIfWindows
139-
@skipIf(archs=no_match(["x86_64"]))
140136
def test_missingArgInRunInTerminalLauncher(self):
141137
if not self.isTestSupported():
142138
return
@@ -152,7 +148,6 @@ def test_missingArgInRunInTerminalLauncher(self):
152148

153149
@skipIfLinux # FIXME: doesn't seem to work on Ubuntu 16.04.
154150
@skipIfWindows
155-
@skipIf(archs=no_match(["x86_64"]))
156151
def test_FakeAttachedRunInTerminalLauncherWithInvalidProgram(self):
157152
if not self.isTestSupported():
158153
return
@@ -180,7 +175,6 @@ def test_FakeAttachedRunInTerminalLauncherWithInvalidProgram(self):
180175

181176
@skipIfLinux # FIXME: doesn't seem to work on Ubuntu 16.04.
182177
@skipIfWindows
183-
@skipIf(archs=no_match(["x86_64"]))
184178
def test_FakeAttachedRunInTerminalLauncherWithValidProgram(self):
185179
if not self.isTestSupported():
186180
return
@@ -208,7 +202,6 @@ def test_FakeAttachedRunInTerminalLauncherWithValidProgram(self):
208202

209203
@skipIfLinux # FIXME: doesn't seem to work on Ubuntu 16.04.
210204
@skipIfWindows
211-
@skipIf(archs=no_match(["x86_64"]))
212205
def test_FakeAttachedRunInTerminalLauncherAndCheckEnvironment(self):
213206
if not self.isTestSupported():
214207
return
@@ -230,7 +223,6 @@ def test_FakeAttachedRunInTerminalLauncherAndCheckEnvironment(self):
230223

231224
@skipIfLinux # FIXME: doesn't seem to work on Ubuntu 16.04.
232225
@skipIfWindows
233-
@skipIf(archs=no_match(["x86_64"]))
234226
def test_NonAttachedRunInTerminalLauncher(self):
235227
if not self.isTestSupported():
236228
return

0 commit comments

Comments
 (0)