Return copy of XML dump

vitalybuka · vitalybuka · commit 2ce7ffd2016e · 2017-09-02T05:14:55.000Z
COFF/DriverUtils.cpp uses buffer after WindowsManifestMerger destroyed. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@312408 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/WindowsManifest/WindowsManifestMerger.cpp b/lib/WindowsManifest/WindowsManifestMerger.cpp
@@ -677,7 +677,7 @@ WindowsManifestMerger::WindowsManifestMergerImpl::getMergedManifest() {
     Buffer.reset(Buff);
   }
 
-  return BufferSize ? MemoryBuffer::getMemBuffer(StringRef(
+  return BufferSize ? MemoryBuffer::getMemBufferCopy(StringRef(
                           FROM_XML_CHAR(Buffer.get()), (size_t)BufferSize))
                     : nullptr;
 }

Original file line number	Diff line number	Diff line change
`@@ -677,7 +677,7 @@ WindowsManifestMerger::WindowsManifestMergerImpl::getMergedManifest() {`
`677`	`677`	`Buffer.reset(Buff);`
`678`	`678`	`}`
`679`	`679`
`680`		`- return BufferSize ? MemoryBuffer::getMemBuffer(StringRef(`
	`680`	`+ return BufferSize ? MemoryBuffer::getMemBufferCopy(StringRef(`
`681`	`681`	`FROM_XML_CHAR(Buffer.get()), (size_t)BufferSize))`
`682`	`682`	`: nullptr;`
`683`	`683`	`}`