Stackless issue python#245: check argument types of PyTasklet_BindEx

Check the arguments 'args' and 'kwargs'. This affects also
tasklet.__init__() and tasklet.bind().

(cherry picked from commit ed31277)

Author: Anselm Kruis

Stackless/changelog.txt

@@ -9,6 +9,10 @@ What's New in Stackless 3.X.X?
 
 *Release date: 20XX-XX-XX*
 
+- https://github.com/stackless-dev/stackless/issues/245
+  Prevent a crash, if you call tasklet.__init__() or tasklet.bind() with wrong
+  argument types.
+
 - https://github.com/stackless-dev/stackless/issues/241
   Prevent a crash, if you call tasklet.__setstate__() on a tasklet, that is
   alive.

Stackless/module/taskletobject.c

@@ -291,6 +291,10 @@ PyTasklet_BindEx(PyTaskletObject *task, PyObject *func, PyObject *args, PyObject
 
     if (func != NULL && !PyCallable_Check(func))
         TYPE_ERROR("tasklet function must be a callable or None", -1);
+    if (args != NULL && !PyTuple_Check(args))
+        TYPE_ERROR("tasklet args must be a tuple or None", -1);
+    if (kwargs != NULL && !PyDict_Check(kwargs))
+        TYPE_ERROR("tasklet kwargs must be a dictionary or None", -1);
     if (ts && ts->st.current == task) {
         RUNTIME_ERROR("can't (re)bind the current tasklet", -1);
     }

Stackless/unittests/test_defects.py

@@ -663,6 +663,15 @@ def test_setstate_alive(self):
         self.assertRaisesRegex(RuntimeError, "tasklet is alive", t.__setstate__, state)
 
 
+class TestTaskletBindArgumentTypes(StacklessTestCase):
+    # a test case for https://github.com/stackless-dev/stackless/issues/245
+    def test_bind_args(self):
+        self.assertRaisesRegex(TypeError, "tasklet args must be a tuple or None", stackless.tasklet, lambda:None, 123)
+
+    def test_bind_kwargs(self):
+        self.assertRaisesRegex(TypeError, "tasklet kwargs must be a dictionary or None", stackless.tasklet, lambda:None, None, 456)
+
+
 if __name__ == '__main__':
     if not sys.argv[1:]:
         sys.argv.append('-v')