Skip to content

Commit af1f115

Browse files
authored
fix: Python respects DYN_LOG too (#1486)
1 parent 2ae9ab9 commit af1f115

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

launch/dynamo-run/src/subprocess/sglang_inc.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,13 @@
1717

1818
from dynamo.llm import ModelType, register_llm
1919
from dynamo.runtime import DistributedRuntime, dynamo_worker
20+
from dynamo.runtime.logging import configure_dynamo_logging
2021

2122
# Only used if you run it manually from the command line
2223
DEFAULT_ENDPOINT = "dyn://dynamo.backend.generate"
2324
DEFAULT_MODEL = "Qwen/Qwen3-0.6B"
2425

25-
logging.basicConfig(level=logging.DEBUG)
26+
configure_dynamo_logging()
2627

2728

2829
class Config:

launch/dynamo-run/src/subprocess/trtllm_inc.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
register_llm,
4040
)
4141
from dynamo.runtime import DistributedRuntime, dynamo_worker
42+
from dynamo.runtime.logging import configure_dynamo_logging
4243

4344
# Only used if you run it manually from the command line
4445
DEFAULT_ENDPOINT = "dyn://dynamo.backend.generate"
@@ -50,7 +51,7 @@
5051
# Default buffer size for kv cache events.
5152
DEFAULT_KV_EVENT_BUFFER_MAX_SIZE = 1024
5253

53-
logging.basicConfig(level=logging.DEBUG)
54+
configure_dynamo_logging()
5455

5556

5657
def parse_endpoint(endpoint: str) -> tuple[str, str, str]:

launch/dynamo-run/src/subprocess/vllm_inc.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,13 @@
2828

2929
from dynamo.llm import ModelType, WorkerMetricsPublisher, register_llm
3030
from dynamo.runtime import DistributedRuntime, dynamo_worker
31+
from dynamo.runtime.logging import configure_dynamo_logging
3132

3233
# Only used if you run it manually from the command line
3334
DEFAULT_ENDPOINT = "dyn://dynamo.backend.generate"
3435
DEFAULT_MODEL = "Qwen/Qwen3-0.6B"
3536

36-
logging.basicConfig(level=logging.DEBUG)
37+
configure_dynamo_logging()
3738

3839

3940
class Config:

launch/dynamo-run/src/subprocess/vllm_v1_inc.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,13 @@
4040
register_llm,
4141
)
4242
from dynamo.runtime import Component, DistributedRuntime, dynamo_worker
43+
from dynamo.runtime.logging import configure_dynamo_logging
4344

4445
# Only used if you run it manually from the command line
4546
DEFAULT_ENDPOINT = "dyn://dynamo.backend.generate"
4647
DEFAULT_MODEL = "Qwen/Qwen3-0.6B"
4748

48-
logging.basicConfig(level=logging.DEBUG)
49+
configure_dynamo_logging()
4950
logger = logging.getLogger(__name__)
5051

5152

0 commit comments

Comments
 (0)