Skip to content

Commit 905e935

Browse files
Merge pull request #292 from alexarchambault/updates
Updates
2 parents 2b55092 + c205c35 commit 905e935

File tree

5 files changed

+19
-41
lines changed

5 files changed

+19
-41
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
SCALA: [2.12.13, 2.13.5]
16+
SCALA: [2.12.13, 2.13.6]
1717
steps:
1818
- uses: actions/checkout@v2
1919
- uses: coursier/cache-action@v6
2020
- uses: laughedelic/coursier-setup@v1
2121
with:
2222
jvm: 8
2323
apps: sbt-launcher
24-
- run: sbt ++$SCALA_VERSION test evictionCheck compatibilityCheck
24+
- run: sbt ++$SCALA_VERSION test mimaReportBinaryIssues
2525
env:
2626
SCALA_VERSION: ${{ matrix.SCALA_VERSION }}
2727

build.sbt

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ inThisBuild(List(
2121
)
2222
))
2323

24+
val previousVersions = Set.empty[String]
25+
lazy val mimaSettings = Def.settings(
26+
mimaPreviousArtifacts := previousVersions.map(organization.value %% moduleName.value % _)
27+
)
2428

2529
lazy val core = crossProject(JVMPlatform, JSPlatform)
2630
.jsConfigure(_.disablePlugins(MimaPlugin))
@@ -30,9 +34,7 @@ lazy val core = crossProject(JVMPlatform, JSPlatform)
3034
libraryDependencies += Deps.dataClass % Provided
3135
)
3236
.jvmSettings(
33-
compatibilitySettings,
34-
mimaPreviousArtifacts := mimaPreviousArtifacts.value
35-
.filter(!_.revision.startsWith("0.7."))
37+
mimaSettings
3638
)
3739

3840
lazy val coreJvm = core.jvm
@@ -42,7 +44,7 @@ lazy val `joda-time` = project
4244
.dependsOn(coreJvm)
4345
.settings(
4446
shared,
45-
compatibilitySettings,
47+
mimaSettings,
4648
plotlyPrefix,
4749
libraryDependencies += Deps.jodaTime
4850
)
@@ -56,7 +58,7 @@ lazy val render = crossProject(JVMPlatform, JSPlatform)
5658
plotlyPrefix
5759
)
5860
.jvmSettings(
59-
compatibilitySettings,
61+
mimaSettings,
6062
mimaCurrentClassfiles := shadedPackageBin.value,
6163
Mima.renderFilters,
6264
shadedModules += Deps.argonautShapeless.value.module,
@@ -170,8 +172,7 @@ lazy val demo = project
170172
.commonJSName("PrismScala")
171173
.dependsOn("prism-java.js")
172174
),
173-
generateCustomSources,
174-
evictionRules += "org.scala-js" % "scalajs-dom_*" % "semver"
175+
generateCustomSources
175176
)
176177

177178
lazy val tests = project
@@ -192,7 +193,7 @@ lazy val almond = project
192193
.dependsOn(coreJvm, renderJvm)
193194
.settings(
194195
shared,
195-
compatibilitySettings,
196+
mimaSettings,
196197
plotlyPrefix,
197198
libraryDependencies += Deps.almondScalaApi % "provided"
198199
)

project/Deps.scala

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,14 @@ object Deps {
88
import Def.setting
99

1010
def almondScalaApi = "sh.almond" %% "jupyter-api" % "0.11.2"
11-
def argonautShapeless = setting("com.github.alexarchambault" %%% "argonaut-shapeless_6.2" % "1.2.0")
11+
def argonautShapeless = setting("com.github.alexarchambault" %%% "argonaut-shapeless_6.3" % "1.3.0")
1212
def dataClass = "io.github.alexarchambault" %% "data-class" % "0.2.5"
1313
def jodaTime = "joda-time" % "joda-time" % "2.10.10"
1414
def rhino = "org.mozilla" % "rhino" % "1.7.13"
15-
def shapeless = setting("com.chuusai" %%% "shapeless" % "2.3.3")
16-
def scalacheckShapeless = setting("com.github.alexarchambault" %%% "scalacheck-shapeless_1.14" % "1.2.0-1")
15+
def shapeless = setting("com.chuusai" %%% "shapeless" % "2.3.7")
16+
def scalacheckShapeless = setting("com.github.alexarchambault" %%% "scalacheck-shapeless_1.15" % "1.3.0")
1717
def scalajsDom = setting("org.scala-js" %%% "scalajs-dom" % "1.1.0")
18-
def scalatags = setting("com.lihaoyi" %%% "scalatags" % "0.9.3")
18+
def scalatags = setting("com.lihaoyi" %%% "scalatags" % "0.9.4")
1919
def scalaTest = "org.scalatest" %% "scalatest" % "3.2.9"
20-
def utest = setting("com.lihaoyi" %%% "utest" % "0.6.6")
2120

2221
}

project/Settings.scala

Lines changed: 3 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
import com.jsuereth.sbtpgp._
33
import sbt._
44
import sbt.Keys._
5-
import sbtevictionrules.EvictionRulesPlugin.autoImport._
65

76
object Settings {
87

@@ -88,7 +87,7 @@ object Settings {
8887
)
8988

9089
private val scala212 = "2.12.13"
91-
private val scala213 = "2.13.5"
90+
private val scala213 = "2.13.6"
9291

9392
private lazy val isAtLeastScala213 = Def.setting {
9493
import Ordering.Implicits._
@@ -98,11 +97,7 @@ object Settings {
9897
lazy val shared = Def.settings(
9998
crossScalaVersions := Seq(scala213, scala212),
10099
scalaVersion := scala213,
101-
resolvers ++= Seq(
102-
"Webjars Bintray" at "https://dl.bintray.com/webjars/maven/",
103-
Resolver.sonatypeRepo("releases"),
104-
"jitpack" at "https://jitpack.io"
105-
),
100+
resolvers += "jitpack" at "https://jitpack.io",
106101
libraryDependencies ++= {
107102
if (isAtLeastScala213.value) Nil
108103
else Seq(compilerPlugin("org.scalamacros" % "paradise" % "2.1.1" cross CrossVersion.full))
@@ -111,28 +106,13 @@ object Settings {
111106
scalacOptions ++= {
112107
if (isAtLeastScala213.value) Seq("-Ymacro-annotations")
113108
else Nil
114-
},
115-
evictionRules += "org.scala-js" %% "scalajs-library" % "semver"
116-
)
117-
118-
lazy val compatibilitySettings = Def.settings(
119-
sbtcompatibility.SbtCompatibilityPlugin.autoImport.compatibilityIgnored ++= Seq(
120-
// former dependency of core, now marked as "provided"
121-
"io.github.alexarchambault" %% "data-class",
122-
// transitive dependency of data-class
123-
"org.scala-lang" % "scala-reflect"
124-
)
109+
}
125110
)
126111

127112
lazy val plotlyPrefix = {
128113
name := "plotly-" + name.value
129114
}
130115

131-
lazy val utest = Seq(
132-
libraryDependencies += Deps.utest.value % "test",
133-
testFrameworks += new TestFramework("utest.runner.Framework")
134-
)
135-
136116
val gitLock = new Object
137117

138118
def runCommand(cmd: Seq[String], dir: File): Unit = {

project/plugins.sbt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
addSbtPlugin("com.geirsson" % "sbt-ci-release" % "1.5.7")
2-
addSbtPlugin("io.github.alexarchambault.sbt" % "sbt-compatibility" % "0.0.8")
3-
addSbtPlugin("io.github.alexarchambault.sbt" % "sbt-eviction-rules" % "0.2.0")
42
addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.9.1")
5-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.5.0")
3+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.5.1")
64
addSbtPlugin("org.portable-scala" % "sbt-scalajs-crossproject" % "1.0.0")
75
addSbtPlugin("org.scala-js" % "sbt-jsdependencies" % "1.0.2")
86
addSbtPlugin("io.get-coursier" % "sbt-shading" % "2.0.1")

0 commit comments

Comments
 (0)